Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow new versions of the shell extension to be installed over the one bundled with the Krita installer #10

Closed
alvinhochun opened this issue Jun 7, 2016 · 1 comment

Comments

@alvinhochun
Copy link
Owner

Currently, the Krita installer force-remove the shell extension, and the shell extension won't install if Krita is installed.

The ultimate idea is to allow the user to install a newer version of the shell extension over an existing Krita installation, so to allow the user to update the shell extension without updating Krita (which is, btw, not exactly the intended use.)

If a new version of the shell extension is installed, then the Krita uninstaller would need to properly uninstall the new version. Three ways to deal with this:

  • Embed the shell extension installer within the Krita installer. The shell extension installer has to accept path to krita.exe from the command line. When uninstalling Krita, just execute the shell extension uninstaller too.
    • It just seems weird?...
  • Save install log and use it in the uninstaller, the shell extension installers can change the install log or place a new install log, so that the uninstaller can use them to remove the new version of the shell extension properly
    • Probably the cleanest way, but how should I generate the install log?
  • In the Krita uninstaller, look for the uninstaller for the shell extension, and use it to uninstall the shell extension instead of using the included functions.
    • Probably the easiest way.
@alvinhochun
Copy link
Owner Author

Opted for the easiest way... Turned out to be not so easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant