Setting arrowDirection to FPPopoverArrowDirectionLeft, arrow is right-pointing

[markd2]

Hi!

When I set FPPopoverArrowDirectionRight, my popover appears in the right place. If I use FPPopoverArrowDirectionLeft, it appears in the same place as FPPopoverArrowDirectionRight. There's plenty of room around the origin point.

Sample project at http://borkware.com/hacks/Popupinator.zip - pretty much just has a button in the middle of an ipad, and a segmented control that lets you choose the arrow direction.

I narrowed it down to bestArrowDirectionAndFrameFromView, the test

    if(wl == best_w || self.arrowDirection == FPPopoverArrowDirectionRight)

Is matching the wl==best_w, ignoring the arrowDirection setting.

Here's a snapshot from the debugger:

if there's anything else I can supply, please let me know. markd@borkware.com

Thanks!
++md

[alvises]

Thank you very much for the code you are providing! I'm going to analyze this.

[alvises]

Fixed! Was in that line of code

    if(wl == best_w || self.arrowDirection == FPPopoverArrowDirectionRight)

so if wl == best_w was ignoring the forcing of the direction

now is

    if((wl == best_w || self.arrowDirection == FPPopoverArrowDirectionRight) && self.arrowDirection != FPPopoverArrowDirectionLeft)

[alvises]

I'm committing, I have put your github id under contributors, thanks