perf(scan): reduce childNotes scan level to avoid performance issue

now at depth of 1, only parentNote get scanned; childNotes get scanned starting from depth of 2
aidenlx · Aug 28, 2021 · 6b89405 · 6b89405
1 parent 32a3874
commit 6b89405
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/modules/scan.ts b/src/modules/scan.ts
@@ -95,7 +95,8 @@ export const scanNote = (
           } else if (
             key === "childNotes" &&
             (dive === undefined || dive) &&
-            Array.isArray(obj[key])
+            Array.isArray(obj[key]) &&
+            accu < depth - 1
           ) {
             try {
               value = obj.childNotes.map((v) => scan(v, true, accu + 1));
@@ -145,7 +146,8 @@ const getScanFunc = (depth: number) => {
           } else if (
             key === "childNotes" &&
             (dive === undefined || dive) &&
-            Array.isArray(obj[key])
+            Array.isArray(obj[key]) &&
+            accu < depth - 1
           ) {
             try {
               value = (obj[key] as any[]).map((v) => scan(v, true, accu + 1));