Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract out coins into their own file #5

Open
alxwrd opened this issue Oct 5, 2018 · 0 comments
Open

Extract out coins into their own file #5

alxwrd opened this issue Oct 5, 2018 · 0 comments

Comments

@alxwrd
Copy link
Owner

alxwrd commented Oct 5, 2018

Currently, the only valid coin set is GBP. It would be good to be able to use different currencies.

The file structure could become

coinhandler/
├── __init__.py
├── coinhandler.py
├── collections.py
└── coins/
    ├── __init__.py
    ├── gbp.py
    ├── usd.py
    └── etc..

With usage being

import coinhandler
from coinhandler.coins import gbp  # Required, if not all coins will be `Coin`

__init__.py for coins/ will contain the base definition of Coin.

This is related to #2, with the added thought being it'd be nice to be able to remove a whole module.

coinhandler.Coin.remove_subcoins(gbp)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant