Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot access on default tabs #42

Closed
edgarasben opened this issue Jan 16, 2022 · 3 comments
Closed

Cannot access on default tabs #42

edgarasben opened this issue Jan 16, 2022 · 3 comments
Labels
question Further information is requested

Comments

@edgarasben
Copy link

I cannot access Omni on default browser tab states like in an empty tab.

But I noticed my other browser extension shortcuts work, e.g. Notion:
image

@yoroshikun
Copy link
Contributor

This is a restriction on how the current implementation is developed. Dupe of #28 #27 and #21

Notion works because they are using the popup interface which is compatible with default tabs etc.

@alyssaxuu
Copy link
Owner

Yeah, I don't really know what to do here. Here's a few options I am thinking about:

  • If on the new tab page and trying to open Omni, open a new page that has Omni open automatically. Try to see if the new tab page can also be closed. This could work in theory, although unsure what page should be opened. Maybe a blank one (I could create a blank page within the extension for example), or bring the user to the homepage of their default search engine and inject it there?

  • Create some sort of popup (same as Notion) so this way I could inform the user that Omni won't work there. It could be used to put all sorts of settings, although it would mean that Omni wouldn't open in one click by clicking on the toolbar icon anymore. This still doesn't solve the Command + K problem.

  • Make the icon red / greyed out in the new tab page to show that it's disabled. This might not be clear enough to the user though, and it might look like it's broken.

What do you think would be the best approach?

@alyssaxuu alyssaxuu added the question Further information is requested label Jan 16, 2022
@alyssaxuu
Copy link
Owner

alyssaxuu commented Jan 16, 2022

I ended up doing the first option. If you close Omni, it goes back to the page you were before. Better than nothing I think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants