Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some favicons are missing #50

Closed
edgarasben opened this issue Jan 17, 2022 · 3 comments
Closed

Some favicons are missing #50

edgarasben opened this issue Jan 17, 2022 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@edgarasben
Copy link

Mabe a default favicon is needed in these cases:
image
@alyssaxuu alyssaxuu added the help wanted Extra attention is needed label Jan 17, 2022
@alyssaxuu
Copy link
Owner

I am aware of the issue. I have set onerror + onload (to check if the image has dimensions, as a fallback to onerror) events to the images, but they don't always seem to trigger annoyingly. Not sure why :(

@edgarasben
Copy link
Author

Maybe the event has to "await" for the images to fetch first? Just a super random guess, didn't look into code.

@alyssaxuu
Copy link
Owner

Managed to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edgarasben @alyssaxuu