Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Favicons from suggestions break cookie creation in some websites #55

Closed
gsabater opened this issue Jan 18, 2022 · 1 comment
Closed

Comments

@gsabater
Copy link

Hello,

I have notices that I can't login to my phpmyadmin server because the browser refuses to create the session cookie.
Upon further investigation, looks there is a request to an http page inside the login page, which breaks the security and prevents the site from creating cookies. View attachment.

image

From what i can see, the omnibox is loading an item from my history, which is a localhost server without https, and thus rendering the whole site insecure and then i cannot login.

I have verified this by disabling the extension and then i can login without problems.

I suggest you eiter

  • dont inject the omnibox DOM directly into the page
  • dont perform searches on page init until the user invoques the omnibox
  • dont display images until the user opens the box
@alyssaxuu
Copy link
Owner

I've just updated the extension (will go live in a few minutes, max in an hour).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants