-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compilation support for Java 8 & Java 11 #184
Comments
I'm happy to make the changes once someone decides approach |
Hi Steven, let’s review the dependency to upgrade it. https://mvnrepository.com/artifact/org.mockito/mockito-core Juan Antonio |
all tests run and succeed with the latest version, and as it's mockito, its touch is confined to test suites
|
Hi @steve-donovan, I was reviewed again the issue, and you are using a non LTS JVM version (Java 15). The last LTS JVM versions are:
Source: https://www.oracle.com/java/technologies/java-se-support-roadmap.html Did you test with Java 17 the solution that you mention? |
Hi @jabrena I had not tried 17 - I'll try doing so shortly and will let you know the result. |
Hi @jabrena Beyond JDK 15 you get a Lombok error. I'm looking into it now |
Maybe, it is related with this issue: and it is necessary to wait for a new version to improve the support for Java 17. |
yeah, it was in a way, and that issue helped a lot. I actually solved it for lombok but now have a single test failing
I'm investigating now. |
Hi @jabrena the breaking test is due to a call to internal api issue described here [adoptium/adoptium-support/issues/199] |
It is great:
How did you do it? The Base64 issue was registered here: #139 In next months, we want to increase the minimum JVM version supported to Java 8, and later Java 11, so we could use the native Base64 support: |
bumper mockito version to solve original issue, then added/amended scoped lines for bumped version of lombok
|
ok - got it
and TripParser change:
I can raise a PR if you like 😊 |
Give me the opportunity to think about it. I believe, that it is not possible to do it in a single round everything:
We could update the pipeline build_gradle.yml in this way to compile for multiple JVM versions with no change in the build system:
If you observe, in one round, we could increase the compilation support for Java 8 & Java 11 but not for Java 17 immediately, because it is necessary to increase the minimum compilation support for Java 8 (We are discussing internally). In your side, using sdk cli tool, you could switch to different JVM versions in one second, for example from java 17 to java 19 (next september) or to java 11 or to java 8. :) If you like, we could receive a PR for actions 1 & 3 in this round. Juan Antonio |
Description
When having a later JDK installed >8, the amadeus-java tests fail.
Steps to Reproduce
./gradlew test
Expected Behavior: all tests from master branch to pass
Actual Behavior: almost half of the tests fail
Stable Behavior? 100%
Versions
JDK 15
Mac O/S 12.4
Cause
The issue is the removal of unsafe operations from JDK 9 onward.
Solution
update the version of mockito-core (simplest) or add the following to build.gradle file (obviously replacing my path with an env variable). User experience would suffer with the latter solution as they'd need to install another JRE and set up an env variable.
should be more like:
The text was updated successfully, but these errors were encountered: