Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Trip Parser API #28

Closed
anthonyroux opened this issue Jul 23, 2019 · 1 comment · Fixed by #104
Closed

Add support for Trip Parser API #28

anthonyroux opened this issue Jul 23, 2019 · 1 comment · Fixed by #104
Assignees
@siddydutta
Labels
enhancement New feature or request Hacktoberfest

Comments

@anthonyroux
Copy link
Contributor

anthonyroux commented Jul 23, 2019 •
edited by tsolakoua

Support for Trip Parser v3.
@anthonyroux anthonyroux added the enhancement New feature or request label Jul 23, 2019
@anthonyroux anthonyroux mentioned this issue Oct 21, 2019
Merged
@anthonyroux anthonyroux reopened this Mar 18, 2020
@tsolakoua tsolakoua mentioned this issue Mar 20, 2020
Closed
@siddydutta
Copy link
Contributor

Hi @tsolakoua!
A solution could be to send a File instance to a TripParser client's post() method which in turn Base64 encodes the file contents and sends it to the API. (Similar to the Python SDK) I've tested this approach and it seems to be working.
If this is acceptable, I can create a PR for Trip Parser support.

@siddydutta siddydutta mentioned this issue Oct 2, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siddydutta siddydutta

Labels
enhancement New feature or request Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Trip Parser API v3 siddydutta/amadeus-java
3 participants
@anthonyroux @tsolakoua @siddydutta