This repository has been archived by the owner on Sep 17, 2020. It is now read-only.
Supporting 3-rd party detectors (rules) #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- multiple messages.xml are read and merged - Java SPI mechanism for discovering 3-rd party detectors - default detector package is still needs to be used - huntbugs maven plugin is not affected (to configure it standard tag 'dependencies' inside tag 'plugin' could be used) - removed redundant public modifiers at interface nested classes (public by default)
|
Adding third-party detectors is definitely planned. I will review your PR and possibly accept it (or modify somehow). But beware that at current development stage I cannot guarantee the API stability. It's possible that after updating to the new HuntBugs version you will have to add some changes to your detectors. |
|
Sure, we understand the risk. |
volkovs
added a commit
to volkovs/huntbugs
that referenced
this pull request
Sep 10, 2016
- sample project for custom detectors - detectors are automatically tested with sample code in test scope - sample project with HuntBugs maven plugin with custom detectors - production code in sample project is not annotated with @AssertWarning - sample project might be used for demonstration of project configuration without custom detectors as well
Merged
|
Closed as superceded by #20. |
volkovs
added a commit
to volkovs/huntbugs
that referenced
this pull request
Sep 13, 2016
- introducing helper class to test detectors (to be reused) - custom detectors can be located in custom packages - minor refactoring
volkovs
added a commit
to volkovs/huntbugs
that referenced
this pull request
Sep 13, 2016
- plugin currently supports single detectors package for simplicity - introducing helper class to test detectors (to be reused) - custom detectors can be located in custom packages - minor refactoring - added license agreement headers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to write our own project specific rules. So, this is currently a working solution for Maven. I didn't tested Ant or Gradle, but should be as simple as adding your artifact (with custom detectors) to (HuntBugs plugin) classpath.
What do you think?