Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support semantic-release higher than version 19 #235

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: support semantic-release higher than version 19 #235

wants to merge 2 commits into from

Conversation

g-ongenae
Copy link

Fix #176.

Tested on @algoan/pubsub for publishing v6:

jackmoxley
jackmoxley reviewed Oct 30, 2023
View reviewed changes
Copy link

@jackmoxley jackmoxley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't removing the reload going to mean we are using the same semantic-release/npm each time?

@g-ongenae
Copy link
Author

@jackmoxley, That depends on how await import behaves, so I don't know for sure. If you have a way to test that, I'll gladly take a look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackmoxley jackmoxley jackmoxley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

semantic release v20 support
2 participants
@g-ongenae @jackmoxley