Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3 compatible? #18

Open
bbrendon opened this issue Aug 18, 2017 · 2 comments · May be fixed by #24
Open

python3 compatible? #18

bbrendon opened this issue Aug 18, 2017 · 2 comments · May be fixed by #24

Comments

@bbrendon
Copy link 

Traceback (most recent call last):
  File "log.py", line 29, in <module>
    log_line_data = line_parser(loop) #We are using the apache parser as specified above
  File "/usr/local/lib/python3.4/dist-packages/apache_log_parser/__init__.py", line 246, in parse
    match = self.log_line_regex.match(log_line)
TypeError: can't use a string pattern on a bytes-like object
@amandasaurus
Copy link
Owner

Hi, I initially designed this with python2 in mind, I don't think i've tried it with py3. It would be nice to have py3 compatibility, but I have no time to work on this now. Patches welcome!

@scottwilliambeasley scottwilliambeasley mentioned this issue Apr 8, 2018
Merged
@scottwilliambeasley
Copy link

Love your module. Patch submitted!

@scottwilliambeasley scottwilliambeasley linked a pull request Apr 8, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix bug with regex matching when using Python 3 scottwilliambeasley/apache-log-parser
3 participants
@amandasaurus @bbrendon @scottwilliambeasley