Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching annosidebar view from full content to fields for better templating #130

Open
amandavisconti opened this issue Jun 16, 2015 · 3 comments

Comments

@amandavisconti
Copy link
Owner

Probably need to include flag programmatically. Also community tagging field and its resulting tags?

Anno highlights/highlighted annos was broken before switched to fields (going back to full content doesn't fix it). Not a typo in the template (returning to non-collapsible template doesn't fix). Blanking out custom.css doesn't fix either. Possibly switching to fields resulted in different NID form labels on return (breaking highlighted annos hardcode)? Firebug+highlighted annos doesn't look like any IDs got changed by testing fields instead of full content. Going to try deleting view/reimporting (and then check that uses same form IDs). Had been cache flushing, but additionally flushed Views cache specifically. Nope. Firebug looks the same; both live and local are loading all the AnnoJS scripts.

Wow—so somehow the div Annotator is assigned to got messed up (it was on .node-book p), and setting it back to .node-type-book .col-md-12 p brought annotation back.

@amandavisconti amandavisconti added this to the 1.1 (Bloomsday wasn't actually the natural time to upgrade the site) milestone Jun 16, 2015
@amandavisconti
Copy link
Owner Author

If annotations highlight clicking ever seems broken, verify that there are non-private annotations on that page.

@amandavisconti
Copy link
Owner Author

[ ] Currently issue where highlight's annos are sorted to top, but other annos appear in sidebar after them (also ignoring the specification of only showing top two annos per highlight, or at least only showing the related annos).

Changed content=NID filter to "required" = initial view empty, highlight click only sends one annotation even when two tied to a highlight (i.e. whole point of highlighted annos—sending multiple anno NIDs to filter—is broken)

Going to try switching in old clone of annosidebar view. Didn't help, but might try much older version from repo.

Note that everything above may be invalidated by FF/Firebug not clearing cache bug (needed to restart, source code view concurrently broke).

[ ] Switching between forcing fields and just full content leaves fields we want out of full content, so let's try just fields instead so we can place hidden metadata in the collapse section via the tpl.php

#111 (minipager breaking drawer+Highlighted Annos) fixed by displaying all, but now Highlighted Annos isn't working—places correct annos at top of view but displays rest of annos on page beneath.

This was fixed by removing "sort by post date (ascending)" from the view.

@amandavisconti
Copy link
Owner Author

Note another Drupaler discussed the widescreen issue and his hack here: https://www.drupal.org/node/2194419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant