Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make It Mobile Responsive #21

Closed
amanjagdev opened this issue Oct 4, 2020 · 11 comments
Closed

Make It Mobile Responsive #21

amanjagdev opened this issue Oct 4, 2020 · 11 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Good for people who are doing Hacktoberfest 2021 help wanted Extra attention is needed

Comments

@amanjagdev
Copy link
Owner

In order to make the web app mobile responsive, the following tasks need to be implemented.

  • Only the left panel should be visible on the mobile view.
  • If people are on a mobile device, it should show a small card at the bottom which will say "open this website on the desktop to access it".
  • The visitor's and users count along with the GitHub buttons should also be visible on the mobile view also.
@amanjagdev amanjagdev added enhancement New feature or request good first issue Good for newcomers hacktoberfest Good for people who are doing Hacktoberfest 2021 help wanted Extra attention is needed labels Oct 4, 2020
@vj-abishek
Copy link

@amanjagdev Can I work in it? Then please assign me.

@amanjagdev
Copy link
Owner Author

@vj-abishek Sure.. you can work on that 👍

@vj-abishek
Copy link

vj-abishek commented Oct 4, 2020

"open this website on the desktop to access it". @amanjagdev This should be fixed at the bottom?

@lakbychance
Copy link
Contributor

lakbychance commented Oct 4, 2020

Hey @amanjagdev can I pick this up too ?

I have few ideas :-

  1. Your instructions panel becomes irrelevant for mobile and tablets so user-agent should be used as a means to identify the device type and not render it.

  2. So in mobile/tablets instead of instructions panel, show them disclaimer to open the same in desktop. Also Settings Pane won't be rendered.

  3. For desktop, a user might open browser window in split mode so using width as a means to distinguish wouldn't be best alternative. Instead from a certain width - make your app vertically scrollable by placing Settings Pane beneath your Info Pane and also update Instructions Panel text to reflect the same.

  4. Also I think it's good to abstract Github metrics in a separate component and reuse it as per requirement.

If you think these are valid suggestions, let me know and I will start working on them.

@amanjagdev
Copy link
Owner Author

@vj-abishek I will review your PR In a while...
@lapstjup Those suggestions look great to me... You can also make a PR for the same.

Whosoever's implementation will be good will be accepted and merged :)

@amanjagdev
Copy link
Owner Author

@lapstjup There is one thing I would like to add, It's regarding your point 3.
Making the application vertically scrollable and placing InfoPane above SettingsPane would destroy the overall look of it on bigger screen sizes and ratio.
Maybe if you can use queries for the device they are using then after a certain point, the settings pane would be shifted downwards. That would be a better solution in my eyes.
Can you do that?
Rest all the points are great and you may start implementing it.

@vj-abishek
Copy link

vj-abishek commented Oct 4, 2020

@amanjagdev I'm working on the PR.

@lakbychance
Copy link
Contributor

@amanjagdev Hey yes I will do that as per width only. I like the current look and feel with left - right focus. I will identify a suitable breakpoint and do the vertical change.

Also I will start working on them probably after an hour or so ? I hope time isn't a problem here.

@vj-abishek
Copy link

vj-abishek commented Oct 4, 2020

@amanjagdev here is the preview URL https://react-builder-2f3sx4qo3.vercel.app/. Here is mine #22. Made with pure css

@lakbychance
Copy link
Contributor

This took longer than expected but here is the pull request for this issue - #23.

@amanjagdev
Copy link
Owner Author

The issue has been resolved by #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Good for people who are doing Hacktoberfest 2021 help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants