fix: memory leak by weakly capturing deferred object

amanjeetsingh150 · Dec 25, 2023 · 8942da8 · 8942da8
1 parent 3d64eb4
commit 8942da8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/ThirdParty/Deferred/Deferred/Deferred.swift b/ThirdParty/Deferred/Deferred/Deferred.swift
@@ -133,10 +133,10 @@ public func all<T>(_ deferreds: [Deferred<T>]) -> Deferred<[T]> {
     results.reserveCapacity(deferreds.count)
 
     var block: ((T) -> ())!
-    block = { t in
+    block = { [weak combined] t in
         results.append(t)
         if results.count == deferreds.count {
-            combined.fill(results)
+            combined?.fill(results)
         } else {
             deferreds[results.count].upon(block)
         }