Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General project restructure. #102

Merged
merged 2 commits into from Oct 26, 2021
Merged

General project restructure. #102

merged 2 commits into from Oct 26, 2021

Conversation

JuaniBattiston
Copy link
Contributor

  • Removed duplicated bot constructor.
  • Fixed prefix.txt not being used at all.
  • Renamed app.py to bot.py (Will make more sense in future prs).
  • Minor formatting.

@JuaniBattiston
General project restructure.
f78bc8f 
Removed duplicated bot constructor.
Fixed prefix.txt not being used at all.
Renamed app.py to bot.py (Will make more sense in future prs).
Minor formatting.
@JuaniBattiston
Copy link
Contributor Author

These changes are ment as a base for the next pr. Let me know what you think.

@amanjha8100
Copy link
Owner

@Batucho, I will check this out in my local, if everything works fine then will merge this!

@amanjha8100
Copy link
Owner

Hey @Batucho , just one suggestion please do change the bot.py again to app.py as it is related to PROCFILE and documentation related to deployment. It can be changed but few users who don't code are using this and therefore I don't want them to go through the PROCFILE, worker etc. Just look into this point.

@JuaniBattiston
Copy link
Contributor Author

Sure. I'll show you what my idea was with this bot.py file in the next pr. I'll edit this once I finish smt.

@JuaniBattiston
Copy link
Contributor Author

There you go @amanjha8100

@amanjha8100
Copy link
Owner

I will check this out and merge it tomorrow morning!

@amanjha8100 amanjha8100 added enhancement New feature or request hacktoberfest hacktoberfest-accepted Hactoberfest 2021 labels Oct 26, 2021
@amanjha8100 amanjha8100 merged commit a3b63c0 into amanjha8100:main Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanjha8100 amanjha8100 amanjha8100 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest hacktoberfest-accepted Hactoberfest 2021
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JuaniBattiston @amanjha8100