fix: When using domain-based routing, use defaultLocale of a domain instead of the top-level one in case no other locale matches better on the domain
#1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of the top-level one in case no other locale matches better on the domain
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #998
Note that the
defaultLocaleof a domain is used if no other locale matches better. However, if a domain supports multiple locales, the best-matching one will be selected based on theaccept-languageheader. If you want to always use thedefaultLocalein case no prefix is provided, then you can turn offlocaleDetection.