Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow usage of getTranslations({namespace}) without TypeScript integration for messages #630

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

amannn
Copy link
Owner

@amannn amannn commented Nov 15, 2023

Fixes #625

Copy link

vercel bot commented Nov 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-intl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 9:58am
next-intl-example-app-router ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 9:58am

@amannn amannn changed the title fix: Allow usage of getTranslations({namespace}) without TypeScription integration for messages fix: Allow usage of getTranslations({namespace}) without TypeScript integration for messages Nov 15, 2023
type Messages = typeof import('./messages/en.json');
declare interface IntlMessages extends Messages {}
// type Messages = typeof import('./messages/en.json');
// declare interface IntlMessages extends Messages {}
Copy link
Owner Author

@amannn amannn Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Revert

@amannn amannn marked this pull request as ready for review November 15, 2023 10:03
@amannn amannn merged commit 62cf29c into main Nov 15, 2023
5 checks passed
@amannn amannn deleted the fix/625-gettranslations-type branch November 15, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

t from getTranslations({locale, namespace}) can`t receive any arguments when not using typed messages
1 participant