feat: Add localePrefix for navigation APIs for an improved initial render of Link when using localePrefix: never. Also fix edge case in middleware when using localized pathnames for redirects that remove a locale prefix (fixes an infinite loop).
#678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AhmedBaset
reviewed
Nov 29, 2023
| isLocalHref(href) && locale | ||
| ? // Potentially the href shouldn't be prefixed, but to determine this we | ||
| isLocalHref(href) && (localePrefix !== 'never' || isChangingLocale) | ||
| ? // For the `localePrefix: 'as-necessary' strategy, the href shouldn't |
There was a problem hiding this comment.
Suggested change
| ? // For the `localePrefix: 'as-necessary' strategy, the href shouldn't | |
| ? // For the `localePrefix: 'as-needed' strategy, the href shouldn't |
There was a problem hiding this comment.
Good catch, thanks @A7med3bdulBaset!
… a localized pathname
amannn
changed the title
localePrefix for navigation APIslocalePrefix for navigation APIs and fix edge case in middleware when using localized pathnames for redirects that remove a locale prefix
amannn
changed the title
localePrefix for navigation APIs and fix edge case in middleware when using localized pathnames for redirects that remove a locale prefixlocalePrefix for navigation APIs for an improved initial render of Link when using localePrefix: never. Also fix edge case in middleware when using localized pathnames for redirects that remove a locale prefix
amannn
changed the title
localePrefix for navigation APIs for an improved initial render of Link when using localePrefix: never. Also fix edge case in middleware when using localized pathnames for redirects that remove a locale prefixlocalePrefix for navigation APIs for an improved initial render of Link when using localePrefix: never. Also fix edge case in middleware when using localized pathnames for redirects that remove a locale prefix (fixes an infinite loop).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By accepting an optional
localePrefixfor the navigation APIs, we can get the initial render of thehrefofLinkright iflocalePrefix: 'never'is set. This can be helpful if domain-based routing is used and you have a single locale per domain.Note that this change is backward-compatible. It's now recommended to set the
localePrefixfor the navigation APIs to get improved behavior forLinkin caselocalePrefix: 'never'is used, but otherwise your app will keep working with the previous behavior.Ref #444