fix: Allow to call getRequestConfig
in outer module closure in a Client Component module graph
#687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #685
This is fixed for compatibility, since we've silently supported this pattern previously. However, it's still not recommended to call
getRequestConfig
in a Client Component module graph as the function can't do anything useful there. Instead, you can extract shared config likelocales
to a file likesrc/navigation.ts
or any other module that is then imported into Client and Server Components.