feat: Add support for basePath in middleware and navigation APIs
#699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…annn # Conflicts: # packages/next-intl/src/middleware/NextIntlMiddlewareConfig.tsx # packages/next-intl/src/middleware/getAlternateLinksHeaderValue.tsx # packages/next-intl/src/middleware/middleware.tsx # packages/next-intl/src/middleware/resolveLocale.tsx # packages/next-intl/test/middleware/middleware.test.tsx
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
amannn
commented
Dec 6, 2023
| @@ -187,19 +194,19 @@ export default function createMiddleware<Locales extends AllLocales>( | |||
| ); | |||
|
|
|||
| if (hasLocalePrefix) { | |||
| const basePath = getNormalizedPathname( | |||
There was a problem hiding this comment.
Removed getNormalizedPathname here because it's not necessary (already applied above)
amannn
changed the title
basePathbasePath in middleware and navigation APIs
amannn
changed the title
basePath in middleware and navigation APIsbasePath in middleware and navigation APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need for a new config option,
next-intlwill automatically pick up thebasePathyou've configured innext.config.js. Note however that you should make sure that you match/explicitly in your middlewarematcher(see the updated docs).The only integration points are:
basePathfor redirects, as Next.js doesn't handle this internallybasePathfor rewrites, as Next.js doesn't handle this internallybasePathfor alternate linksThis PR is based on the initial work in #589 by @Robjam
Closes #589
Closes #243