Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for macOS. #190

Merged
merged 1 commit into from Jul 10, 2022
Merged

Fixes for macOS. #190

merged 1 commit into from Jul 10, 2022

Conversation

AndreasPantle
Copy link
Contributor

@AndreasPantle AndreasPantle commented Mar 27, 2022

It solves the issues:

#49
#27

@amanusk
Copy link
Owner

amanusk commented Jun 22, 2022

Thank you for the PR!
Sorry it took me so long to notice it. Need to check my notifications :)

I don't currently have hardware to test this on. What did you use to test this?
Thanks!

Edit:
Oh, I see, it tries to probe the sensors and not assume they are supported by psuitl. Yea, that should be the better approach.
I was trying to avoid necessary try-catches, but this is what needed in this case

@AndreasPantle
Copy link
Contributor Author

I did a test on a MacBook Pro and an older MacMini. But I think it should't depending on the model.

I have no possibility to catch the errors in other cases. Guess it seems the only way, otherwise:

>>> import platform
>>> platform.system()
'Darwin'

But this wouldn't be better...?

@amanusk amanusk merged commit 231a5af into amanusk:master Jul 10, 2022
@AndreasPantle AndreasPantle deleted the fixes_for_macos branch July 11, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants