Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect resource by whole hostname, not only 2. level domain #33

Open
iBobik opened this issue Oct 23, 2017 · 1 comment
Open

Detect resource by whole hostname, not only 2. level domain #33

iBobik opened this issue Oct 23, 2017 · 1 comment

Comments

@iBobik
Copy link

iBobik commented Oct 23, 2017

Currently it is not possible to use different code for services what has the same 2. level domain but different TDL - example.com, example.org, videos.example.com

How about to rewrite resources, so key will be hostname or some matching/wildcharts/regexp string?

@amarcu5
Copy link
Owner

amarcu5 commented Jul 20, 2018

My apologies, long overdue a response, this is definitely something that I considered but had decided against for two reasons: 1) Lack of services with overlapping domains - I've yet to come across two services that would benefit from such support 2) Performance - PiPer was initially designed to be injected into all sites and I wanted to optimise the fast path

I do think this is worth reconsidering at some point and I'll leave this issue open to anyone keen on supporting two services that might benefit from this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants