Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual studio project #62

Closed
voed opened this issue Nov 15, 2019 · 3 comments · Fixed by #64
Closed

Visual studio project #62

voed opened this issue Nov 15, 2019 · 3 comments · Fixed by #64
Labels
Projects

Comments

@voed
Copy link
Contributor

voed commented Nov 15, 2019

Meson has built-in VS project generator but its completely fucked up and needs a lot of fixes after generation. Why dont just create project once and add it to repository?

@Amaroq7 Amaroq7 added this to To do in Maintenance via automation Nov 16, 2019
@Amaroq7
Copy link
Owner

Amaroq7 commented Nov 16, 2019

This could be done, the only concern I have is those files could go easily out of date, since not everyone uses visual studio for development and the project is still in early development, so I expect lots of changes happen in those files. Sure they could be edited by hand but there's no guarantee that they'll be working properly.

If there are people who use visual studio for building and are willing to keep an eye on those files whether they work as they should, I see no problem to add them.

@voed
Copy link
Contributor Author

voed commented Nov 16, 2019

I can do that. But what about SPConfig file? Its generated by meson. When "commit sha" can be just replaced by static text(as long as its 3rd party user build), version is hardcoded in meson.build.
Maybe we can create some version file?

@Amaroq7
Copy link
Owner

Amaroq7 commented Nov 16, 2019

Version and commit sha could be hardcoded in f.e. msvc20xx/SPConfig.hpp. I'd also add some define like SP_USE_MSVC_CUSTOM_VERSION to include appropriate SPConfig.hpp.

Maintenance automation moved this from To do to Done Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Maintenance
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants