Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target Fixer API on API Layer and modernize #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Target Fixer API on API Layer and modernize #46

wants to merge 1 commit into from

Conversation

jhaarden
Copy link

  • Update to the new Fixer API endpoint on API Layer
  • Re-add support for changing base currency.
  • Always use TLS encrypted endpoint, since this is once again supported by Free Plan.
  • Add new API function, available_currencies(), for listing supported currency symbols.
  • Replace unit tests based on nosetest with unit tests based on pytest (nose is not supported by modern Python 3 versions).
  • Remove support for Python 2.
  • Add type hints for all methods.
  • Changed dependencies listed in requirements.txt to be type >= instead of ==.

Fixes #39

@jhaarden
Target Fixer API on API Layer and modernize
89d50a9 
- Update to the new Fixer API endpoint on API Layer
- Re-add support for changing base currency.
- Always use TLS encrypted endpoint, since this is once again supported by Free
  Plan.
- Add new API function, available_currencies(), for listing supported currency
  symbols.
- Replace unit tests based on nosetest with unit tests based on pytest (nose is
  not supported by modern Python 3 versions).
- Remove support for Python 2.
- Add type hints for all methods.
- Changed dependencies listed in requirements.txt to be type >= instead of ==.

Fixes amatellanes#39
@jhaarden
Copy link
Author

Hi @amatellanes,

Is there any chance you will have a look at this pull request for me?

@xsaren11
Copy link

Can you approve pull request
I would like to request HA team to add your package to integrations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove pinning
2 participants
@jhaarden @xsaren11