Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Age distributions #205

Merged
merged 30 commits into from
Jan 21, 2024
Merged

Age distributions #205

merged 30 commits into from
Jan 21, 2024

Conversation

robynstuart
Copy link
Contributor

No description provided.

@robynstuart robynstuart marked this pull request as draft January 14, 2024 23:57
@@ -97,7 +103,7 @@ def update_results(self, n_new, sim):
def finalize(self, sim):
super().finalize(sim)
self.results['cumulative'] = np.cumsum(self.results['new'])
self.results['cbr'] = np.divide(self.results['new'], sim.results['n_alive'], where=sim.results['n_alive']>0)
self.results['cbr'] = 1000*np.divide(self.results['new'], sim.results['n_alive'], where=sim.results['n_alive']>0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this use units instead of 1000?

self.results['cumulative'] = np.cumsum(self.results['new'])
self.results['cmr'] = np.divide(self.results['new'], sim.results['n_alive'], where=sim.results['n_alive']>0)
self.results['cmr'] = 1000*np.divide(self.results['new'], sim.results['n_alive'], where=sim.results['n_alive']>0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again here, units?

@robynstuart robynstuart marked this pull request as ready for review January 16, 2024 01:30
Copy link
Contributor

@cliffckerr cliffckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, seems like this is mostly/all changes from the other PR being ported?

@cliffckerr cliffckerr merged commit 5d4182b into main Jan 21, 2024
2 checks passed
@cliffckerr cliffckerr deleted the age-distributions branch January 21, 2024 23:37
@cliffckerr cliffckerr restored the age-distributions branch January 21, 2024 23:37
@cliffckerr cliffckerr deleted the age-distributions branch January 21, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants