Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue with the voice-sample where silence was removed? #13

Open
steff1193 opened this issue Nov 25, 2016 · 2 comments
Open

Continue with the voice-sample where silence was removed? #13

steff1193 opened this issue Nov 25, 2016 · 2 comments

Comments

@steff1193
Copy link

In Recognito.java method extractFeatures there is a line voiceDetector.removeSilence(voiceSample, sampleRate);. Shoud'nt it be voiceSample = voiceDetector.removeSilence(voiceSample, sampleRate); so that you actually use the output from removeSilence going forward in the method?
@amaurycrickx
Copy link
Owner

correct, well spotted !!!

@isadoravs
Copy link

isadoravs commented Nov 28, 2017 •
edited

Hello, in the same method (extractFeatures) in the line normalizer.normalize(voiceSample, sampleRate) shouldn't be voiceSample = normalizer.normalize(voiceSample, sampleRate)? And the normalize method shouldn't return a double[] audioSample?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steff1193 @amaurycrickx @isadoravs