Square-root in EuclideanDistanceCalculator.java

[steff1193]

In distances/EuclideanDistanceCalculator.java method getDistance, you sum the squares of all the diffs. Shouldnt you do square-root on this sum before returning?

[amaurycrickx]

you're right, I guess this shouldn't be called Euclidean distance anymore

[amaurycrickx]

Do you think I'm right in believing that not applying square-root on the sum helps keeping spread bigger and thus helps when more voice prints are added to the system?

[steff1193]

Yeah, I had the same thought, that, the way it is used, it probably makes things better to leave it as it is. But you should use a different name, because some day, when used in another context, it may be important that it is actually correct euclidean distance that is calculated. If nothing else, it is just really bad naming :-)