Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add daily/weekly/monthly notifications #236

Open
amaurymartiny opened this issue Oct 2, 2019 · 15 comments
Open

Add daily/weekly/monthly notifications #236

amaurymartiny opened this issue Oct 2, 2019 · 15 comments
Assignees

Comments

@amaurymartiny
Copy link
Owner

@amaurymartiny amaurymartiny commented Oct 2, 2019

The idea here is to show regular notifications on the user's phone, to remind him/her of the number of cigarettes he/she is smoking.

We would have the following options:

  • daily notification
  • weekly notification
  • monthly notification
  • pollution peak notification (notification when pollution is higher than recommended) leave this for later)

This user's preference should be stored in AsyncStorage. The UI for now is not decided, so a simple Picker in the About.tsx page would do.

If it's daily, we can show the notification at 10am. Weekly: Sunday 10pm. Monthly: 1st day of each month at 10 am.

Docs: https://docs.expo.io/versions/v35.0.0/sdk/notifications/

@kartik-budhiraja

This comment has been minimized.

Copy link
Contributor

@kartik-budhiraja kartik-budhiraja commented Oct 2, 2019

@amaurymartiny I would love to work on this issue if it's available.

@amaurymartiny

This comment has been minimized.

Copy link
Owner Author

@amaurymartiny amaurymartiny commented Oct 2, 2019

Yes, of course! I just assigned you, ping me here or on https://spectrum.chat/shootismoke if you any help!

@matepapp

This comment has been minimized.

Copy link
Contributor

@matepapp matepapp commented Oct 5, 2019

@kartik-budhiraja can I help somehow? are you still working on the issue?

@kartik-budhiraja

This comment has been minimized.

Copy link
Contributor

@kartik-budhiraja kartik-budhiraja commented Oct 5, 2019

@matepapp I am going to look into this issue this week. I will let you know if we can split up the work if you want to help too.

@97hknl

This comment has been minimized.

Copy link

@97hknl 97hknl commented Oct 14, 2019

Wow, cool idea! I would love to work on this issue as well !!

@amaurymartiny

This comment has been minimized.

Copy link
Owner Author

@amaurymartiny amaurymartiny commented Oct 14, 2019

It's been 9 days and I didn't hear back from @kartik-budhiraja, so @97hknl I guess you can take it.

Unless @matepapp is still interested in doing it?

@matepapp

This comment has been minimized.

Copy link
Contributor

@matepapp matepapp commented Oct 14, 2019

you can work on it @97hknl 👍

@kartik-budhiraja

This comment has been minimized.

Copy link
Contributor

@kartik-budhiraja kartik-budhiraja commented Oct 14, 2019

@amaurymartiny , @97hknl I am currently in progress on this issue, will create a PR today, sorry for the delay!

@97hknl

This comment was marked as off-topic.

Copy link

@97hknl 97hknl commented Oct 14, 2019

you can work on it @97hknl 👍

I am trying to set up my environment. What should I fill in the below params in app.json?

"organization": "YOUR_SENTRY_ORG",
"project": "YOUR_SENTRY_PROJECT",
"authToken": "null"

which are all properties of hooks beneath the githubUrl.

@amaurymartiny

This comment was marked as off-topic.

Copy link
Owner Author

@amaurymartiny amaurymartiny commented Oct 14, 2019

You can leave them as-is, they are only needed for publishing the app

@97hknl

This comment was marked as off-topic.

Copy link

@97hknl 97hknl commented Oct 14, 2019

I have troubles openinig the app in the emulator, on load, I get an error called "Invalid Dsn" with a huge stack trace. Any idea how to fix this?

@amaurymartiny

This comment was marked as off-topic.

Copy link
Owner Author

@amaurymartiny amaurymartiny commented Oct 14, 2019

Hey, yes. Could you put null (without quotes) to all fields in app.json where you didn't put tokens? In particular to the sentryPublicDsn field, which causes this error.

Could you create a new issue, or use https://spectrum.chat/shootismoke?tab=posts for other questions? Thanks!

@97hknl

This comment was marked as off-topic.

Copy link

@97hknl 97hknl commented Oct 14, 2019

Hey, yes. Could you put null (without quotes) to all fields in app.json where you didn't put tokens? In particular to the sentryPublicDsn field, which causes this error.

Could you create a new issue, or use https://spectrum.chat/shootismoke?tab=posts for other questions? Thanks!

I still get the same error, after setting everything to null. Should I create a new issue for this?

@amaurymartiny

This comment was marked as off-topic.

Copy link
Owner Author

@amaurymartiny amaurymartiny commented Oct 14, 2019

Should I create a new issue for this?

Yes, I'll have a look into it!

kartik-budhiraja added a commit to kartik-budhiraja/shoot-i-smoke that referenced this issue Oct 15, 2019
@amaurymartiny

This comment has been minimized.

Copy link
Owner Author

@amaurymartiny amaurymartiny commented Oct 16, 2019

@97hknl (and others) If you want to think about this comment: #292 (review)

Do you have other ideas on how to achieve this functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.