Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd daily/weekly/monthly notifications #236
Comments
This comment has been minimized.
This comment has been minimized.
@amaurymartiny I would love to work on this issue if it's available. |
This comment has been minimized.
This comment has been minimized.
Yes, of course! I just assigned you, ping me here or on https://spectrum.chat/shootismoke if you any help! |
This comment has been minimized.
This comment has been minimized.
@kartik-budhiraja can I help somehow? are you still working on the issue? |
This comment has been minimized.
This comment has been minimized.
@matepapp I am going to look into this issue this week. I will let you know if we can split up the work if you want to help too. |
This comment has been minimized.
This comment has been minimized.
Wow, cool idea! I would love to work on this issue as well !! |
This comment has been minimized.
This comment has been minimized.
It's been 9 days and I didn't hear back from @kartik-budhiraja, so @97hknl I guess you can take it. Unless @matepapp is still interested in doing it? |
This comment has been minimized.
This comment has been minimized.
you can work on it @97hknl |
This comment has been minimized.
This comment has been minimized.
@amaurymartiny , @97hknl I am currently in progress on this issue, will create a PR today, sorry for the delay! |
This comment was marked as off-topic.
This comment was marked as off-topic.
I am trying to set up my environment. What should I fill in the below params in app.json? "organization": "YOUR_SENTRY_ORG", which are all properties of hooks beneath the githubUrl. |
This comment was marked as off-topic.
This comment was marked as off-topic.
You can leave them as-is, they are only needed for publishing the app |
This comment was marked as off-topic.
This comment was marked as off-topic.
I have troubles openinig the app in the emulator, on load, I get an error called "Invalid Dsn" with a huge stack trace. Any idea how to fix this? |
This comment was marked as off-topic.
This comment was marked as off-topic.
Hey, yes. Could you put Could you create a new issue, or use https://spectrum.chat/shootismoke?tab=posts for other questions? Thanks! |
This comment was marked as off-topic.
This comment was marked as off-topic.
I still get the same error, after setting everything to null. Should I create a new issue for this? |
This comment was marked as off-topic.
This comment was marked as off-topic.
Yes, I'll have a look into it! |
This comment has been minimized.
This comment has been minimized.
@97hknl (and others) If you want to think about this comment: #292 (review) Do you have other ideas on how to achieve this functionality? |
The idea here is to show regular notifications on the user's phone, to remind him/her of the number of cigarettes he/she is smoking.
We would have the following options:
pollution peak notification (notification when pollution is higher than recommended)leave this for later)This user's preference should be stored in AsyncStorage. The UI for now is not decided, so a simple Picker in the About.tsx page would do.
If it's daily, we can show the notification at 10am. Weekly: Sunday 10pm. Monthly: 1st day of each month at 10 am.
Docs: https://docs.expo.io/versions/v35.0.0/sdk/notifications/