Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add daily/weekly/monthly notifications #236

Closed
amaury1093 opened this issue Oct 2, 2019 · 15 comments · Fixed by #439
Closed

Add daily/weekly/monthly notifications #236

amaury1093 opened this issue Oct 2, 2019 · 15 comments · Fixed by #439
Assignees
Labels
F-planned New feature or request

Comments

@amaury1093
Copy link
Member

amaury1093 commented Oct 2, 2019

The idea here is to show regular notifications on the user's phone, to remind him/her of the number of cigarettes he/she is smoking.

We would have the following options:

  • daily notification
  • weekly notification
  • monthly notification
  • pollution peak notification (notification when pollution is higher than recommended) leave this for later)

This user's preference should be stored in AsyncStorage. The UI for now is not decided, so a simple Picker in the About.tsx page would do.

If it's daily, we can show the notification at 10am. Weekly: Sunday 10pm. Monthly: 1st day of each month at 10 am.

Docs: https://docs.expo.io/versions/v35.0.0/sdk/notifications/

@kartik-budhiraja
Copy link
Contributor

@amaurymartiny I would love to work on this issue if it's available.

@amaury1093
Copy link
Member Author

amaury1093 commented Oct 2, 2019

Yes, of course! I just assigned you, ping me here or on https://spectrum.chat/shootismoke if you any help!

@matepapp
Copy link
Contributor

matepapp commented Oct 5, 2019

@kartik-budhiraja can I help somehow? are you still working on the issue?

@kartik-budhiraja
Copy link
Contributor

@matepapp I am going to look into this issue this week. I will let you know if we can split up the work if you want to help too.

@97hknl
Copy link

97hknl commented Oct 14, 2019

Wow, cool idea! I would love to work on this issue as well !!

@amaury1093
Copy link
Member Author

It's been 9 days and I didn't hear back from @kartik-budhiraja, so @97hknl I guess you can take it.

Unless @matepapp is still interested in doing it?

@matepapp
Copy link
Contributor

you can work on it @97hknl 👍

@kartik-budhiraja
Copy link
Contributor

@amaurymartiny , @97hknl I am currently in progress on this issue, will create a PR today, sorry for the delay!

@97hknl

This comment has been minimized.

@amaury1093

This comment has been minimized.

@97hknl

This comment has been minimized.

@amaury1093

This comment has been minimized.

@97hknl

This comment has been minimized.

@amaury1093

This comment has been minimized.

kartik-budhiraja added a commit to kartik-budhiraja/shoot-i-smoke that referenced this issue Oct 15, 2019
@amaury1093
Copy link
Member Author

@97hknl (and others) If you want to think about this comment: #292 (review)

Do you have other ideas on how to achieve this functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-planned New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants