Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set up disqus #42

Closed
jenlky opened this issue May 21, 2020 · 5 comments
Closed

Unable to set up disqus #42

jenlky opened this issue May 21, 2020 · 5 comments
Labels
bug Something isn't working
Projects

Comments

@jenlky
Copy link

jenlky commented May 21, 2020

Describe the bug
Unable to set up disqus for my posts.

To Reproduce
I have added disqusShortname = "jenlky" to the config.toml. Neither did I set the frontmatter comment = false.

It exists in comment.html too:

{{ if .Site.Params.disqusShortname }}
<div class="post-comment-wrapper">
  {{ template "_internal/disqus.html" . }}
</div>
{{ end }}

Expected behavior
By right, disqus should appear below all the posts.

Screenshots

Environment
Your Hugo version, generated from hugo version.

I downgraded my hugo version from v0.69.0 to v0.68.3:

Hugo Static Site Generator v0.68.3-157669A0 windows/amd64 BuildDate: 2020-03-24T12:04:36Z
Chrome Version 80.0.3987.163 (Official Build) (64-bit)

Additional context

@jenlky jenlky closed this as completed May 21, 2020
@jenlky jenlky reopened this May 21, 2020
@AmazingRise AmazingRise added the bug Something isn't working label May 22, 2020
@AmazingRise AmazingRise added this to To Do in 1.2.0 via automation May 22, 2020
@AmazingRise
Copy link
Owner

Please try this commit, and see if Disqus works.

b4c734f

Now it works for me. If yours also works fine, even when online, please close this issue.
Thanks for your support.

@AmazingRise AmazingRise moved this from To Do to In Progress in 1.2.0 May 24, 2020
@jenlky
Copy link
Author

jenlky commented May 25, 2020

I've git pull the theme and ensured nothing is overriding the theme changes. However, it still doesn't work for me and I'm not sure what's the problem.

Let me know if you need any code/screenshots to show it!

@AmazingRise
Copy link
Owner

AmazingRise commented May 25, 2020

Now please visit https://amazingrise.net/posts/building-openjdk/
You may see a Disqus comment at the bottom, like this:
image

Here is a part of my config.toml:

[params]
subtitle = "Rise's Blog"
enableGitalk = false
enableReadingTime = true
# enablevaline = true
disqusShortname = "jenlky"

@jenlky
Copy link
Author

jenlky commented May 25, 2020

I found out what's the problem - I didn't put my disqusShortname config under params in config.toml 🤦‍♂️

Thanks for sharing your screenshots and config settings! 谢谢🙏

@jenlky jenlky closed this as completed May 25, 2020
1.2.0 automation moved this from In Progress to Done May 25, 2020
@AmazingRise
Copy link
Owner

haha, anyway, thanks for your feedback!
感谢反馈!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
1.2.0
  
Done
Development

No branches or pull requests

2 participants