Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate separate set of exports for tests #22

Closed
mijamo911 opened this issue Dec 28, 2016 · 3 comments
Closed

Investigate separate set of exports for tests #22

mijamo911 opened this issue Dec 28, 2016 · 3 comments

Comments

@mijamo911
Copy link

Currently Ion.ts exports a bunch of classes just for test visibility. We may want to look into having two sets of exports, one for consumers and one for tests so that we're not leaking too many implementation details

@mijamo911
Copy link
Author

Addressed by #28

@therapon
Copy link
Contributor

Things look better but I think there is more to be done here. So leaving this issue as open

@zslayton
Copy link
Contributor

This is mostly fixed, with remaining visibility issues being tracked separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants