Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an allElements() method alongside elements() #693

Closed
zslayton opened this issue May 7, 2021 · 2 comments
Closed

Add an allElements() method alongside elements() #693

zslayton opened this issue May 7, 2021 · 2 comments
Labels
v5.0.0 issues for v5.0.0 release
Milestone

Comments

@zslayton
Copy link
Contributor

zslayton commented May 7, 2021

v4.2.0 added support for structs with repeated field names, e.g.

{
  foo: 1,
  foo: true,
  foo: bar
}

To preserve backwards compatibility, existing struct accessor methods (get, fields) continued to return deduplicated results, using the value associated with the last appearance of each field name. New flavors of those methods (getAll, allFields) were added that would instead return an array with every value associated each field name.

We have not yet added an allElements method for the elements method. A call to elements with the sample struct above would return [bar] while the allElements method would return [1, true, bar].

@desaikd desaikd added the v5.0.0 issues for v5.0.0 release label Mar 2, 2023
@desaikd
Copy link
Contributor

desaikd commented Mar 2, 2023

Express allElements() behavior in elements() with v5.0.0 release.

@desaikd desaikd added this to the M7 (v5.0.0) milestone Mar 2, 2023
@desaikd
Copy link
Contributor

desaikd commented Apr 20, 2023

fixed with #754

@desaikd desaikd closed this as completed Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5.0.0 issues for v5.0.0 release
Projects
None yet
Development

No branches or pull requests

2 participants