Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break up element_test_vectors to improve test build times #678

Closed
zslayton opened this issue Nov 10, 2023 · 1 comment
Closed

Break up element_test_vectors to improve test build times #678

zslayton opened this issue Nov 10, 2023 · 1 comment
Labels
code-quality Issues of style, consistency, or factoring enhancement New feature or request

Comments

@zslayton
Copy link
Contributor

The file tests/element_test_vectors.rs hosts our integration with ion-tests, the spec compliance test suite.

Running cargo build --timings --all-features --tests generates this report:

image

As this illustrates, most of the time needed to build the test suite is spent on that file, which contains several different configurations of the ion-tests runner. We should break it up into several files so they can be built in parallel.
@zslayton zslayton added enhancement New feature or request code-quality Issues of style, consistency, or factoring labels Nov 10, 2023
@zslayton zslayton mentioned this issue Nov 10, 2023
Merged
@zslayton
Copy link
Contributor Author

Fixed by #679. After:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality Issues of style, consistency, or factoring enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zslayton