Joint IC/SL Integration #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giove91
reviewed
Aug 3, 2021
datasets.py
Outdated
| - python prepare_multi_woz.py --data-dir ./trade-dst/data | ||
| 7. move the saved splits to ./data/multi_woz | ||
| - mv ./trade-dst/data/splits ./data/multi_woz_2.1 | ||
| MultiWoz dataset (Dialogue State Tracking). |
There was a problem hiding this comment.
These changes to the description of the MultiWoz dataset should not be made!
|
Thanks for the PR. Per discussion, I think moving parts related to intent classification to IC/SL dataclass rather than having it in the baseline dataset class would be cleaner. :) |
added 2 commits
August 10, 2021 16:15
…ase class and into JointICSLFormat. Add label and format error detection to joint IC/SL
|
Done! All changes to base class reverted; all intent-classification-related logic is now contained in either SnipsDataset, ATISDataset, or JointICSLFormat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added ATIS and Snips support to
datasets.pyand a joint IC/SL format tooutput_formats.py. Also added configs toconfig.iniand updated the evaluation logic to include intent classification accuracy.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.