Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In script shell/eval_retrieval.sh #8

Closed
AllenPu opened this issue Mar 7, 2022 · 5 comments
Closed

In script shell/eval_retrieval.sh #8

AllenPu opened this issue Mar 7, 2022 · 5 comments

Comments

@AllenPu
Copy link

AllenPu commented Mar 7, 2022

In line 34, is that should be python3 eval_retrieve_knn_pred.py instead of python3 eval_retrieval_knn_pred.py?
It seems no file named eval_retrieval_knn_pred.py
@AllenPu
Copy link
Author

AllenPu commented Mar 7, 2022

and should be bash shell/eval_retrieve.sh?

@KuangHaofei
Copy link
Contributor

Yes, it is! Sorry for the typo, we will fix it later!
Thanks for your reminder!

@bryanyzhu
Copy link
Contributor

Hi @KuangHaofei , just curious, will there be a PR to fix this? Thank you.

@KuangHaofei KuangHaofei mentioned this issue May 30, 2022
Merged
@KuangHaofei
Copy link
Contributor

Sorry! I have submitted a new PR for the issue! Please check #10, thanks!

@bryanyzhu
Copy link
Contributor

Thanks, just merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bryanyzhu @KuangHaofei @AllenPu