Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Integrate a bash formatter #103

Open
Mte90 opened this issue May 24, 2024 · 2 comments · May be fixed by #128
Open

[Feature] Integrate a bash formatter #103

Mte90 opened this issue May 24, 2024 · 2 comments · May be fixed by #128
Assignees
@b1ek
Labels
enhancement New feature or request
Milestone
Amber 0.4.0-alpha

Comments

@Mte90
Copy link
Member

Mte90 commented May 24, 2024

After discussing on discord this project jumped as the best one: https://github.com/mvdan/sh

The idea is to add that in the installation process as optional, so Amber when find it can use to prettify the script generated.
@Ph0enixKM Ph0enixKM changed the title Integrate a bash formatter ✨ Integrate a bash formatter May 25, 2024
@b1ek b1ek mentioned this issue May 26, 2024
Open
@b1ek b1ek self-assigned this May 27, 2024
@b1ek b1ek added the enhancement New feature or request label May 27, 2024
@FedericoCeratto
Copy link
Collaborator

I suggest making the formatter configurable (i.e. configure which tool to use) to avoid introducing functional dependencies that could make Amber less easy to package and distribute.

@b1ek
Copy link
Member

b1ek commented May 29, 2024

I suggest making the formatter configurable (i.e. configure which tool to use) to avoid introducing functional dependencies that could make Amber less easy to package and distribute.

i have already scratched up locally a formatting mechanism that looks for installed formatters and selects the first one available, even though the only maintained tool i could find is the one mentioned in the issue description.

@b1ek b1ek added this to the Stable release milestone May 29, 2024
@b1ek b1ek linked a pull request May 30, 2024 that will close this issue
Open
@Ph0enixKM Ph0enixKM changed the title ✨ Integrate a bash formatter [Features] Integrate a bash formatter Jul 7, 2024
@Ph0enixKM Ph0enixKM changed the title [Features] Integrate a bash formatter [Feature] Integrate a bash formatter Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b1ek b1ek

Labels
enhancement New feature or request
Projects
None yet
Milestone
Amber 0.4.0-alpha
Development

Successfully merging a pull request may close this issue.

Integrate shfmt b1ek/Amber
4 participants
@FedericoCeratto @Mte90 @Ph0enixKM @b1ek