Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQlite Versions #296

Closed
Blacksmoke16 opened this issue Oct 19, 2018 · 2 comments
Closed

SQlite Versions #296

Blacksmoke16 opened this issue Oct 19, 2018 · 2 comments

Comments

@Blacksmoke16
Copy link
Contributor

Currently we are only testing the version of SQlite that comes with the crystal ubuntu install. 3.11.0. This is 14 minor versions behind the latest.

Would it be worth to test other versions, or at least use the latest version to test on? I would like to use at least version 3.24.0 which added an upsert feature with the same syntax as PG uses.

https://www.sqlite.org/lang_UPSERT.html

@drujensen
Copy link
Member

drujensen commented Oct 19, 2018

Would it be worth to test other versions, or at least use the latest version to test on? I would like to use at least version 3.24.0 which added an upsert feature with the same syntax as PG uses.

yes. Rule of thumb is test the stable version and one major version previous.

@Blacksmoke16
Copy link
Contributor Author

Blacksmoke16 commented Oct 19, 2018

👍 I'll look into doing this this weekend. Would users who use sqlite be on the latest version? i.e. if I were to refactor the bulk imports to use the new upsert feature, that would break people using versions older than 3.24.0. But if everyone is on newer/newest, it obs wouldnt be an issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants