Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version requirement breaking Amber #44

Closed
dburnsii opened this issue Sep 27, 2019 · 3 comments
Closed

Version requirement breaking Amber #44

dburnsii opened this issue Sep 27, 2019 · 3 comments

Comments

@dburnsii
Copy link

The release of version v0.3.5 includes a requirement for a recent release of crystal-lang/crystal-db ~> v0.7.0. The dependencies for the currently released version of Amber (v0.30.1) and previous releases point to ~> v0.6.0. This is causing shards install to fail, and any project without a shard.lock file pointing to the correct versions fails to build.

A fix for this is to re-release this shard as version v0.3.x, with the version selection of crystal-db removed. Including the version is a good idea though, and it should be released with version v0.4.x to include the change without breaking existing projects.

Discussed with @elorest and he confirmed this as a solution.

@elorest
Copy link
Member

elorest commented Sep 27, 2019

Previous to 0.3.5 micrate pointed to crystal-db without a version. When crystal-db was just updated micrate automatically points to the newest version, while all other shards which depended on crystal-db correctly pointed to 0.6.0. This broke all past and present versions of amber. I'm going to fix this now by:

  1. Releasing 0.3.5 to point to 0.6.0 of crystal-db.
  2. Releasing 0.4.0 to point to 0.7.0 of crystal-db.

@drujensen
Copy link
Member

drujensen commented Sep 27, 2019 via email

@elorest
Copy link
Member

elorest commented Sep 27, 2019

That's fine. Thanks for working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants