Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages for vidyut.kosha #3

Open
akprasad opened this issue Jan 21, 2023 · 0 comments
Open

Improve error messages for vidyut.kosha #3

akprasad opened this issue Jan 21, 2023 · 0 comments

Comments

@akprasad
Copy link
Contributor

akprasad commented Jan 21, 2023 •
edited

If the vidyut_kosha crate fails, our vidyut.kosha wrapper passes through the raw Rust error and doesn't give much insight on how to correct the error.

This is poor UX. In addition to improving the upstream error messages, we should provide informative messages here.

Errors to test:

  • Could not create builder
  • Could not insert key (out of order)
  • Could not insert key (too many duplicates)
  • Could not create kosha
  • Could not load kosha (file doesn't exist)
  • Could not load kosha (file is malformed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akprasad