Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing aiohttp dep #699

Merged
merged 2 commits into from Feb 14, 2019
Merged

add missing aiohttp dep #699

merged 2 commits into from Feb 14, 2019

Conversation

JelleZijlstra
Copy link
Collaborator

Also mark 3.8 as allowed to fail for now; it will fail due to an aiohttp bug.

Fixes #690

Also mark 3.8 as allowed to fail for now; it will fail due to an aiohttp bug.

Fixes psf#690
@JelleZijlstra
Copy link
Collaborator Author

This Travis configuration just doesn't run 3.8 at all, which doesn't seem ideal. Let me try something else.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 912

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+5.7%) to 95.946%

Files with Coverage Reduction New Missed Lines %
tests/test_black.py 2 97.89%
Totals Coverage Status
Change from base Build 910: 5.7%
Covered Lines: 2982
Relevant Lines: 3108

💛 - Coveralls

3 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 912

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+5.7%) to 95.946%

Files with Coverage Reduction New Missed Lines %
tests/test_black.py 2 97.89%
Totals Coverage Status
Change from base Build 910: 5.7%
Covered Lines: 2982
Relevant Lines: 3108

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 912

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+5.7%) to 95.946%

Files with Coverage Reduction New Missed Lines %
tests/test_black.py 2 97.89%
Totals Coverage Status
Change from base Build 910: 5.7%
Covered Lines: 2982
Relevant Lines: 3108

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 912

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+5.7%) to 95.946%

Files with Coverage Reduction New Missed Lines %
tests/test_black.py 2 97.89%
Totals Coverage Status
Change from base Build 910: 5.7%
Covered Lines: 2982
Relevant Lines: 3108

💛 - Coveralls

@coveralls
Copy link

coveralls commented Feb 7, 2019

Pull Request Test Coverage Report for Build 918

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+5.7%) to 95.978%

Files with Coverage Reduction New Missed Lines %
tests/test_black.py 2 97.89%
Totals Coverage Status
Change from base Build 910: 5.7%
Covered Lines: 2983
Relevant Lines: 3108

💛 - Coveralls

@@ -31,6 +31,8 @@ matrix:
python: 3.6
- name: "3.7"
python: 3.7
# aiohttp currently has a bug affecting 3.8
allow_failures:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this to run it needs to also be in the matrix

@zsol zsol merged commit a00f426 into psf:master Feb 14, 2019
@JelleZijlstra JelleZijlstra deleted the corsdep branch February 14, 2019 20:24
@JelleZijlstra
Copy link
Collaborator Author

Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants