False-positive error for Final if it's aliased

[AlexWaygood]

flake8-pyi currently emits a false-positive error for this code, which should be fine:

from typing_extensions import Final as _Final

CONSTANT: _Final = 5

This might be tricky to fix, since we don't currently track whether imports are aliased at all. Came up in python/typeshed#9470

[Avasam]

Similarly, Y036 (Badly defined __exit__ method) will false-positive with a TypeAlias of object (ie: _Unused: TypeAlias = object)

[AlexWaygood]

Similarly, Y036 (Badly defined exit method) will false-positive with a TypeAlias of object (ie: _Unused: TypeAlias = object)

Sure, but I'm gonna say I definitely don't want us to try and fix that one. It's ~reasonable to argue that we should track whether imports are aliased. But constructing a "poor man's symbol table" for the entire module would require whole new level of complexity 😃 it's important to remember that we're just a dumb linter, we're not a type checker 😁

[Avasam]

it's important to remember that we're just a dumb linter, we're not a type checker

Right, you don't have easy access to that kind of information 😅