Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't error on empty files #19

Merged
merged 1 commit into from Jul 17, 2019
Merged

Don't error on empty files #19

merged 1 commit into from Jul 17, 2019

Conversation

aneeshusa
Copy link
Contributor

Empty files can't have any type comments to rewrite,
so skip processing them.

This avoids spurious errors like:

error: tests/__init__.py: string index out of range

@gaborbernat
Copy link
Collaborator

You'll need to resolve the conflict 👍

@aneeshusa
Don't error on empty files
12323be 
Empty files can't have any type comments to rewrite,
so skip processing them.

This avoids spurious errors like:
```
error: tests/__init__.py: string index out of range
```
@aneeshusa
Copy link
Contributor Author

Rebased!

@gaborbernat gaborbernat merged commit 0c81291 into ambv:master Jul 17, 2019
@aneeshusa
Copy link
Contributor Author

Thanks! Any chance you can cut a release on PyPI? Would love to be able to use #18 and #19 easily!

@aneeshusa
Copy link
Contributor Author

@ambv perhaps you can cut a release on PyPI? I'm eagerly awaiting easily being able to use the latest and greatest retype :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aneeshusa @gaborbernat