-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package.json "defines > groupId" field is not being honoured #385
Comments
@thedevopsguyblog This is working using the example project: https://github.com/amclin/aem-packager-example as well as in unit tests. For troubleshooting can you provide:
Lastly, please doublecheck your package.json as the |
Hey @amclin, thanks for responding. I noticed that the example project works on my local and my Jenkins server, so I'm pretty confident i'm just missing something. To be clear, the aem-packager-example has a clientlib.config.js file, do i need my own? I also switched from package.json to a .yml file for troubleshooting and the build is still failing (locally and on Jenkins). Now I'm running this command "aem-packager --config ./aem-packager.yml" options:
srcDir: /app/public/applications
buildDir: target
jcrPath: /apps/corporate-commons/clientlibs/foundation/resources/corporate-frontend-svelte
defines:
artifactId: corporate-frontend-svelte
description: Corporate frontend svelte
groupId: au.industry.city
version: '2.2.2' Below is my package.json.
|
@amclin what do you think? |
@thedevopsguyblog the clientlib.config.js isn't necessary, that's just for the separate
The only thing I can think of is perhaps a typo in Try deleting the |
Closing as it's getting stale and I cannot reproduce |
A note to this. We experienced the same problem and came up to this: With npm 8 (and 7 - but not sure if it was a subversion or 7 overall) adding aem-packager config into package.json will no longer work as the searched keys "npm_package_*" are no longer in process.env (in getFromEnv function). None of the settings are honoured, it looks like mostly due to version is extracted correctly from package.json and the path most likely fits the artifactId, that's why it looks like only groupId is not honoured. I switched to seperate yaml and now it works again, for the moment. |
Interesting.... When I test with NPM 8, the
Edit: |
When building my project (either locally or via Jenkins), the default groupId is loaded instead of what is in "aem-packager" under package.json
Steps to reproduce the behavior:
aem-packager
Expected behavior
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: