Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

excluded-instr output identical to available-instr output #49

Closed
jrmadsen opened this issue Jun 17, 2022 · 0 comments · Fixed by #50 or #51
Closed

excluded-instr output identical to available-instr output #49

jrmadsen opened this issue Jun 17, 2022 · 0 comments · Fixed by #50 or #51
Labels
binary instrumentation Binary instrumentation bug Something isn't working omnitrace-instrument Involves the omnitrace-instrument executable (binary instrumenter)

Comments

@jrmadsen
Copy link
Collaborator

In source/bin/omnitrace/omnitrace.cpp:

https://github.com/AMDResearch/omnitrace/blob/5bdfecb9ddef0863c08cded9ef7d72f7884827ad/source/bin/omnitrace/omnitrace.cpp#L1816

unambiguously copies all of the available module functions into excluded module functions. This should only happen in sampling mode.
@jrmadsen jrmadsen added bug Something isn't working omnitrace-instrument Involves the omnitrace-instrument executable (binary instrumenter) binary instrumentation Binary instrumentation labels Jun 17, 2022
@jrmadsen jrmadsen mentioned this issue Jun 17, 2022
Merged
@jrmadsen jrmadsen mentioned this issue Jun 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
binary instrumentation Binary instrumentation bug Something isn't working omnitrace-instrument Involves the omnitrace-instrument executable (binary instrumenter)
Projects
None yet
Milestone
No milestone
1 participant
@jrmadsen