Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax constraints on faraday and faraday_middleware #19

Open
utkarsh2102 opened this issue Nov 30, 2020 · 2 comments
Open

Relax constraints on faraday and faraday_middleware #19

utkarsh2102 opened this issue Nov 30, 2020 · 2 comments

Comments

@utkarsh2102
Copy link

utkarsh2102 commented Nov 30, 2020

Hi,

behance/behance.gemspec

Lines 20 to 21 in 0b4633c

gem.add_runtime_dependency 'faraday', '~> 0.14.0'
gem.add_runtime_dependency 'faraday_middleware', '~> 0.12.2'

With faraday 1.1.0 and faraday_middleware 1.0.0, behance fails to build/work, only because of the ~> constraints. If it could be >= instead, that'd work great!


Here's a patch:

Author: Utkarsh Gupta <utkarsh@debian.org>
Bug-Debian: https://bugs.debian.org/976160
Last-Update: 2020-11-30

--- a/behance.gemspec
+++ b/behance.gemspec
@@ -17,8 +17,8 @@
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
 
-  gem.add_runtime_dependency     'faraday',            '~> 0.15'
-  gem.add_runtime_dependency     'faraday_middleware', '~> 0.12.2'
+  gem.add_runtime_dependency     'faraday',            '>= 0.15'
+  gem.add_runtime_dependency     'faraday_middleware', '>= 0.12.2'
   gem.add_runtime_dependency     'json',               '~> 2.1'
   gem.add_development_dependency 'webmock',            '~> 3.7'
   gem.add_development_dependency 'rspec',              '~> 3.8'
@amedrz
Copy link
Owner

amedrz commented Dec 1, 2020

Hello @utkarsh2102, thanks for the heads up. Could you please make a PR for this? I'm happy to merge it afterwards.

@mknudsen
Copy link

@amedrz not the original author but I prepared a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants