Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the currency configurable. #9

Merged
merged 1 commit into from
May 23, 2013
Merged

Conversation

askmike
Copy link
Contributor

@askmike askmike commented May 22, 2013

Now the currency of BTCUSD is not hardcoded anymore and can be set using the method setCurrency.

Now the currency of `BTCUSD` is not hardcoded anymore and can be set using the method `setCurrency`.
@ameensol
Copy link
Owner

Thanks, that's a good idea!

ameensol added a commit that referenced this pull request May 23, 2013
Made the currency configurable.
@ameensol ameensol merged commit c492841 into ameensol:master May 23, 2013
@askmike
Copy link
Contributor Author

askmike commented May 24, 2013

Thanks.

Any possibility you could bump the version on npm? That way I can use it in my app.

@ameensol
Copy link
Owner

I'm pretty new to all this, so I'm not exactly sure how to bump the version. I tried to update the version to 1.0.2 and publish again. Did it work?

@askmike
Copy link
Contributor Author

askmike commented May 26, 2013

I'm not that familiar with npm but it appears it did not update yet. You can check the package on npm and see what version is listed there, right now it stills says 1.0.1.

I think the command should be npm publish, but if you have tried that already it may be a caching issue @ npm.

EDIT: now it says 1.0.2 so it's updated, thanks!

@ameensol
Copy link
Owner

Awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants