Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-pty-prebuilt prevents loading #82

Open
bobjunga opened this issue Nov 16, 2019 · 2 comments
Open

node-pty-prebuilt prevents loading #82

bobjunga opened this issue Nov 16, 2019 · 2 comments

Comments

@bobjunga
Copy link

  • OS: Ubuntu
  • OS version: 17.04
  • Atom version: 1.41.0
  • atom-xterm version: 6.50
  • complete error msg from atom console:
    Failed to require the main module of 'atom-xterm' because it requires one or more incompatible native modules (node-pty-prebuilt). Run apm rebuild in the package directory and restart Atom to resolve. requireMainModule @ :11

Issue description
I install atom-xterm via atom package manager and it does not load. In the atom console is that error message (see above).

running apm rebuild completes silently and does not change the behavior.

I went to the the node-pty-prebuilt folder under the atom-xterm package and ran "node-gyp configure; node-gyp build" which was successful. I saw that the pty.node binary did change (using cmp command) but the atom error message stayed the same.

  • electron version 7.1.1
    I did a simple test with electron fiddle that requires node-pty-prebuilt and is gets a similar but more descriptive message in its console:
    Uncaught Error: The module '/tmp/tmp-3288D7paNnpvRzuR/node_modules/node-pty-prebuilt/build/Release/pty.node' was compiled against a different Node.js version using NODE_MODULE_VERSION 67. This version of Node.js requires NODE_MODULE_VERSION 75. Please try re-compiling or re-installing the module (for instance, using npm rebuildornpm install).

I get the same error when I require node-pty instead of prebuilt.

I tried various electron versions and could not find one that uses NODE_MODULE_VERSION 67. IT seems to be one in the 4.x line.

Thanks,

--BobG

@bobjunga
Copy link
Author

FYI, inexplicably, the problem went away :(

I tried many things. Uninstalled everything, cleaned everything, and the problem persisted. Then I installed the "local-storage" atom package to view items in atom's local storage cache. There did not seem to be any relevant keys but, inexplicably, the problem went away :(

@UziTech
Copy link

UziTech commented Feb 15, 2020

I forked atom-xterm, updated everything along with other fixes, and released it as x-terminal since atom-xterm doesn't seem to be maintained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants