Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awesome books: with ES6 #1

Merged
merged 21 commits into from Jul 4, 2022
Merged

Awesome books: with ES6 #1

merged 21 commits into from Jul 4, 2022

Conversation

amejid
Copy link
Owner

@amejid amejid commented Jul 4, 2022

In this PR, the following were implemented:-

  • No linter errors
  • Used correct GitHub flow
  • Used ES6 functions
  • Used modules to separate business logic and display

Copy link

@emmanuellekamwa emmanuellekamwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED 🍾✔🎉
Hello @amejid 👋
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@amejid amejid merged commit 1915c0b into main Jul 4, 2022
@amejid amejid deleted the develop branch July 4, 2022 07:09
@amejid
Copy link
Owner Author

amejid commented Oct 14, 2022

Thank you for reviewing and approving my code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants