Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To Do list: interactive list #4

Merged
merged 6 commits into from Jul 5, 2022
Merged

To Do list: interactive list #4

merged 6 commits into from Jul 5, 2022

Conversation

amejid
Copy link
Owner

@amejid amejid commented Jul 5, 2022

Milestone 3: interactive list

In this PR, the following were implemented:

  • No linter errors
  • Used a correct GitHub flow
  • Update items object's value for completed key upon user actions.
  • Implemented a function for the "Clear all completed"

Copy link

@ShoiraTa ShoiraTa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED ✔️


Hi @amejid ,

Your project is complete! Great job for nailing it right on the first attempt 🥇. There is nothing else to say other than... it's time to merge it 🍾🚢 :shipit: . Congratulations! 🎉💯🌟

Good Points 👍

  • JavaScript files imported as a module ✔️
  • Event listener on the checkbox ✔️
  • completed is updated upon user actions✔️

giphy

Cheers and Happy coding! 👏 👏 👏

Feel free to leave any questions or comments in the PR thread by mentioning my Github username if something is not 100% clear.


As described in the Code reviews limits policy you have limited number of reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.

@amejid amejid merged commit ce93901 into main Jul 5, 2022
@amejid amejid deleted the interactive-list branch July 5, 2022 11:52
@amejid
Copy link
Owner Author

amejid commented Oct 14, 2022

Thank you for reviewing and approving my code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants