print set env message all at once #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
Aug 4, 2017
ament_cmake_test/cmake/run_test.py
Outdated
| @@ -130,6 +130,7 @@ def log(msg, **kwargs): | |||
| if args.env: | |||
| log('-- run_test.py: extra environment variables:') | |||
| previous_key = None | |||
| updated_env_keys = set([]) | |||
There was a problem hiding this comment.
set() is sufficient. No need for the empty list argument.
ament_cmake_test/cmake/run_test.py
Outdated
| @@ -152,7 +155,7 @@ def log(msg, **kwargs): | |||
| value = env[key] + ';' + env_str | |||
| else: | |||
| key, value = separate_env_vars(env_str, 'append-env', parser) | |||
| log(' - {0}={1}'.format(key, value)) | |||
| log(' - {0}+={1}'.format(key, value)) | |||
There was a problem hiding this comment.
This will print e.g.:
- ping+=pong
- ping+=;pong;peng
The += is certainly helpful but it shouldn't include pong in the second line.
There was a problem hiding this comment.
Good point, what about now.
dirk-thomas
approved these changes
Aug 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prints env "set" operation all at once, still prints appends one at a time, since that's a more natural
+=(accumulation) kind of action.